Re: [libvirt] [PATCH v2 2/8] blockcopy: split out virsh implementation

2014-08-26 Thread Eric Blake
On 08/26/2014 09:00 AM, Peter Krempa wrote: > On 08/26/14 13:21, Eric Blake wrote: >> I'm about to extend the capabilities of blockcopy. Hiding a few >> common lines of implementation gets in the way of the new required >> logic, and putting the new logic in the common implementation won't >> bene

Re: [libvirt] [PATCH v2 2/8] blockcopy: split out virsh implementation

2014-08-26 Thread Peter Krempa
On 08/26/14 13:21, Eric Blake wrote: > I'm about to extend the capabilities of blockcopy. Hiding a few > common lines of implementation gets in the way of the new required > logic, and putting the new logic in the common implementation won't > benefit any of the other blockjob operations. Therefo

[libvirt] [PATCH v2 2/8] blockcopy: split out virsh implementation

2014-08-26 Thread Eric Blake
I'm about to extend the capabilities of blockcopy. Hiding a few common lines of implementation gets in the way of the new required logic, and putting the new logic in the common implementation won't benefit any of the other blockjob operations. Therefore, it is simpler to just do the work inline.