Re: [libvirt] [PATCH v2 24/32] tests: Fix memory leak in testCompareXMLToArgvFiles

2019-02-11 Thread Ján Tomko
On Fri, Feb 08, 2019 at 01:37:18PM -0500, John Ferlan wrote: Only one path will consume the @def; otherwise, we need to free it. Signed-off-by: John Ferlan --- tests/storagepoolxml2argvtest.c | 4 1 file changed, 4 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc Description:

Re: [libvirt] [PATCH v2 24/32] tests: Fix memory leak in testCompareXMLToArgvFiles

2019-02-11 Thread Erik Skultety
On Mon, Feb 11, 2019 at 08:18:13AM -0500, John Ferlan wrote: > > > On 2/11/19 7:24 AM, Erik Skultety wrote: > > On Fri, Feb 08, 2019 at 01:37:18PM -0500, John Ferlan wrote: > >> Only one path will consume the @def; otherwise, we need to free it. > >> > >> Signed-off-by: John Ferlan > >> --- > >>

Re: [libvirt] [PATCH v2 24/32] tests: Fix memory leak in testCompareXMLToArgvFiles

2019-02-11 Thread John Ferlan
On 2/11/19 7:24 AM, Erik Skultety wrote: > On Fri, Feb 08, 2019 at 01:37:18PM -0500, John Ferlan wrote: >> Only one path will consume the @def; otherwise, we need to free it. >> >> Signed-off-by: John Ferlan >> --- >> tests/storagepoolxml2argvtest.c | 4 >> 1 file changed, 4

Re: [libvirt] [PATCH v2 24/32] tests: Fix memory leak in testCompareXMLToArgvFiles

2019-02-11 Thread Erik Skultety
On Fri, Feb 08, 2019 at 01:37:18PM -0500, John Ferlan wrote: > Only one path will consume the @def; otherwise, we need to free it. > > Signed-off-by: John Ferlan > --- > tests/storagepoolxml2argvtest.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/tests/storagepoolxml2argvtest.c

[libvirt] [PATCH v2 24/32] tests: Fix memory leak in testCompareXMLToArgvFiles

2019-02-08 Thread John Ferlan
Only one path will consume the @def; otherwise, we need to free it. Signed-off-by: John Ferlan --- tests/storagepoolxml2argvtest.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/storagepoolxml2argvtest.c b/tests/storagepoolxml2argvtest.c index 288b81af1d..f2a8af12b0 100644 ---