Re: [libvirt] [PATCH v2 3/3] Unify int types handling in protocol files

2016-01-11 Thread Martin Kletzander
On Mon, Jan 11, 2016 at 03:34:05AM +0300, Roman Bogorodskiy wrote: From: Jasper Lievisse Adriaanse Some of the protocol files already include handing of the missing int types such as xdr_uint64_t, some don't. To fix it everywhere, move out of the appropriate defines to the

Re: [libvirt] [PATCH v2 3/3] Unify int types handling in protocol files

2016-01-11 Thread Roman Bogorodskiy
Martin Kletzander wrote: > On Mon, Jan 11, 2016 at 03:34:05AM +0300, Roman Bogorodskiy wrote: > >From: Jasper Lievisse Adriaanse > > > >Some of the protocol files already include handing of the missing int > >types such as xdr_uint64_t, some don't. To fix it everywhere,

Re: [libvirt] [PATCH v2 3/3] Unify int types handling in protocol files

2016-01-10 Thread Justin Clift
Should this patch by itself be enough to fix the OSX compilation problem? :) eg should I test it with just this? + Justin On 2016-01-11 00:34, Roman Bogorodskiy wrote: From: Jasper Lievisse Adriaanse Some of the protocol files already include handing of the missing int

Re: [libvirt] [PATCH v2 3/3] Unify int types handling in protocol files

2016-01-10 Thread Roman Bogorodskiy
Justin Clift wrote: > Should this patch by itself be enough to fix the OSX compilation > problem? :) > > eg should I test it with just this? Yeah, it should. One thing, though: it patches the .x files, not the generated files. On OpenBSD I wasn't able to build things from git because rpcgen

[libvirt] [PATCH v2 3/3] Unify int types handling in protocol files

2016-01-10 Thread Roman Bogorodskiy
From: Jasper Lievisse Adriaanse Some of the protocol files already include handing of the missing int types such as xdr_uint64_t, some don't. To fix it everywhere, move out of the appropriate defines to the utils/virxdrdefs.h file and include it where needed. Signed-off-by: