Re: [libvirt] [PATCH v2 3/3] maint: split long lines for BSD syntax-check

2019-01-07 Thread Eric Blake
On 1/7/19 9:39 AM, Ján Tomko wrote: > On Mon, Jan 07, 2019 at 09:11:03AM -0600, Eric Blake wrote: > > [...] >    | $(SED) 's/_("\([^\"]\|\\.\)\+"//;s/[ ]"%s"//' \    | $(GREP) '[ ]"' && \   { echo '$(ME): found unmarked diagnostic(s)' 1>&2; \ >>> >>> With the

Re: [libvirt] [PATCH v2 3/3] maint: split long lines for BSD syntax-check

2019-01-07 Thread Ján Tomko
On Mon, Jan 07, 2019 at 09:11:03AM -0600, Eric Blake wrote: [...]    | $(SED) 's/_("\([^\"]\|\\.\)\+"//;s/[ ]"%s"//' \    | $(GREP) '[ ]"' && \   { echo '$(ME): found unmarked diagnostic(s)' 1>&2; \ With the /dev/null changes removed or justified: I hope that was the

Re: [libvirt] [PATCH v2 3/3] maint: split long lines for BSD syntax-check

2019-01-07 Thread Eric Blake
On 1/7/19 5:00 AM, Ján Tomko wrote: > On Thu, Jan 03, 2019 at 01:41:59PM -0600, Eric Blake wrote: >> Similar to the gnulib changes we just incorporated into maint.mk, >> it's time to use '$(VC_LIST) | xargs program' instead of >> 'program $$($(VC_LIST))', in order to bypass the problem of hitting

Re: [libvirt] [PATCH v2 3/3] maint: split long lines for BSD syntax-check

2019-01-07 Thread Ján Tomko
On Thu, Jan 03, 2019 at 01:41:59PM -0600, Eric Blake wrote: Similar to the gnulib changes we just incorporated into maint.mk, it's time to use '$(VC_LIST) | xargs program' instead of 'program $$($(VC_LIST))', in order to bypass the problem of hitting argv limits due to our large set of files.

[libvirt] [PATCH v2 3/3] maint: split long lines for BSD syntax-check

2019-01-03 Thread Eric Blake
Similar to the gnulib changes we just incorporated into maint.mk, it's time to use '$(VC_LIST) | xargs program' instead of 'program $$($(VC_LIST))', in order to bypass the problem of hitting argv limits due to our large set of files. Drop several uses of $$files as a temporary variable when we