Re: [libvirt] [PATCH v2 3/3] util: Drop virPCIGetAddrString()

2018-09-05 Thread Andrea Bolognani
On Wed, 2018-09-05 at 14:53 +0200, Martin Kletzander wrote: > On Wed, Sep 05, 2018 at 10:09:26AM +0200, Andrea Bolognani wrote: > > for (i = 0; i < *n_vfname; i++) { > > -if (virPCIGetAddrString((*virt_fns)[i]->domain, > > -(*virt_fns)[i]->bus, > > -

Re: [libvirt] [PATCH v2 3/3] util: Drop virPCIGetAddrString()

2018-09-05 Thread Martin Kletzander
On Wed, Sep 05, 2018 at 10:09:26AM +0200, Andrea Bolognani wrote: There's a single user for it which takes an existing virPCIDeviceAddress, passes its various bits to the function which in turn constructs a virPCIDevice and then copies the string representation for the caller to use: we can use v

[libvirt] [PATCH v2 3/3] util: Drop virPCIGetAddrString()

2018-09-05 Thread Andrea Bolognani
There's a single user for it which takes an existing virPCIDeviceAddress, passes its various bits to the function which in turn constructs a virPCIDevice and then copies the string representation for the caller to use: we can use virPCIDeviceAddressAsString() instead and avoid creating the virPCIDe