Re: [libvirt] [PATCH v2 3/3] virt-aa-helper: drop pointer checks in get_files

2019-11-20 Thread Cole Robinson
On 11/20/19 12:25 PM, Jamie Strandboge wrote: > On Wed, 20 Nov 2019, Cole Robinson wrote: > >> On 11/19/19 4:31 PM, Jamie Strandboge wrote: >>> On Thu, 14 Nov 2019, Christian Ehrhardt wrote: >>> It was mentioned that the pointers in loops like: for (i = 0; i < ctl->def->nserials; i++)

Re: [libvirt] [PATCH v2 3/3] virt-aa-helper: drop pointer checks in get_files

2019-11-20 Thread Jamie Strandboge
On Wed, 20 Nov 2019, Cole Robinson wrote: > On 11/19/19 4:31 PM, Jamie Strandboge wrote: > > On Thu, 14 Nov 2019, Christian Ehrhardt wrote: > > > >> It was mentioned that the pointers in loops like: > >> for (i = 0; i < ctl->def->nserials; i++) > >> if (ctl->def->serials[i] ... > >> will

Re: [libvirt] [PATCH v2 3/3] virt-aa-helper: drop pointer checks in get_files

2019-11-20 Thread Cole Robinson
On 11/19/19 4:31 PM, Jamie Strandboge wrote: > On Thu, 14 Nov 2019, Christian Ehrhardt wrote: > >> It was mentioned that the pointers in loops like: >> for (i = 0; i < ctl->def->nserials; i++) >> if (ctl->def->serials[i] ... >> will always be !NULL or we would have a much more serious

Re: [libvirt] [PATCH v2 3/3] virt-aa-helper: drop pointer checks in get_files

2019-11-20 Thread Christian Ehrhardt
On Tue, Nov 19, 2019 at 10:31 PM Jamie Strandboge wrote: > > On Thu, 14 Nov 2019, Christian Ehrhardt wrote: > > > It was mentioned that the pointers in loops like: > > for (i = 0; i < ctl->def->nserials; i++) > > if (ctl->def->serials[i] ... > > will always be !NULL or we would have a

Re: [libvirt] [PATCH v2 3/3] virt-aa-helper: drop pointer checks in get_files

2019-11-19 Thread Jamie Strandboge
On Thu, 14 Nov 2019, Christian Ehrhardt wrote: > It was mentioned that the pointers in loops like: > for (i = 0; i < ctl->def->nserials; i++) > if (ctl->def->serials[i] ... > will always be !NULL or we would have a much more serious problem. > > Simplify the if chains in get_files by

Re: [libvirt] [PATCH v2 3/3] virt-aa-helper: drop pointer checks in get_files

2019-11-14 Thread Cole Robinson
On 11/14/19 6:20 AM, Christian Ehrhardt wrote: > It was mentioned that the pointers in loops like: > for (i = 0; i < ctl->def->nserials; i++) > if (ctl->def->serials[i] ... > will always be !NULL or we would have a much more serious problem. > > Simplify the if chains in get_files by

[libvirt] [PATCH v2 3/3] virt-aa-helper: drop pointer checks in get_files

2019-11-14 Thread Christian Ehrhardt
It was mentioned that the pointers in loops like: for (i = 0; i < ctl->def->nserials; i++) if (ctl->def->serials[i] ... will always be !NULL or we would have a much more serious problem. Simplify the if chains in get_files by dropping these checks. Signed-off-by: Christian Ehrhardt ---