Re: [libvirt] [PATCH v2 3/4] Add a mutex to serialize updates to firewall

2014-01-28 Thread Daniel P. Berrange
On Mon, Jan 27, 2014 at 04:50:56PM -0500, Stefan Berger wrote: On 01/27/2014 12:18 PM, Daniel P. Berrange wrote: The nwfilter conf update mutex previously serialized updates to the internal data structures for firewall rules, and updates to the firewall itself. Since the Hm, wasn't aware

Re: [libvirt] [PATCH v2 3/4] Add a mutex to serialize updates to firewall

2014-01-28 Thread Stefan Berger
On 01/28/2014 06:15 AM, Daniel P. Berrange wrote: On Mon, Jan 27, 2014 at 04:50:56PM -0500, Stefan Berger wrote: On 01/27/2014 12:18 PM, Daniel P. Berrange wrote: The nwfilter conf update mutex previously serialized updates to the internal data structures for firewall rules, and updates to the

Re: [libvirt] [PATCH v2 3/4] Add a mutex to serialize updates to firewall

2014-01-28 Thread Daniel P. Berrange
On Tue, Jan 28, 2014 at 07:31:04AM -0500, Stefan Berger wrote: On 01/28/2014 06:15 AM, Daniel P. Berrange wrote: On Mon, Jan 27, 2014 at 04:50:56PM -0500, Stefan Berger wrote: On 01/27/2014 12:18 PM, Daniel P. Berrange wrote: The nwfilter conf update mutex previously serialized updates to the

Re: [libvirt] [PATCH v2 3/4] Add a mutex to serialize updates to firewall

2014-01-28 Thread Stefan Berger
On 01/28/2014 07:38 AM, Daniel P. Berrange wrote: On Tue, Jan 28, 2014 at 07:31:04AM -0500, Stefan Berger wrote: On 01/28/2014 06:15 AM, Daniel P. Berrange wrote: On Mon, Jan 27, 2014 at 04:50:56PM -0500, Stefan Berger wrote: On 01/27/2014 12:18 PM, Daniel P. Berrange wrote: The nwfilter

[libvirt] [PATCH v2 3/4] Add a mutex to serialize updates to firewall

2014-01-27 Thread Daniel P. Berrange
The nwfilter conf update mutex previously serialized updates to the internal data structures for firewall rules, and updates to the firewall itself. Since the former is going to be turned into a read/write lock instead of a mutex, a new lock is required to serialize access to the firewall itself.

Re: [libvirt] [PATCH v2 3/4] Add a mutex to serialize updates to firewall

2014-01-27 Thread Stefan Berger
On 01/27/2014 12:18 PM, Daniel P. Berrange wrote: The nwfilter conf update mutex previously serialized updates to the internal data structures for firewall rules, and updates to the firewall itself. Since the Hm, wasn't aware (anymore) of this double-purpose. I also hadn't looked at this

Re: [libvirt] [PATCH v2 3/4] Add a mutex to serialize updates to firewall

2014-01-27 Thread Eric Blake
On 01/27/2014 10:18 AM, Daniel P. Berrange wrote: The nwfilter conf update mutex previously serialized updates to the internal data structures for firewall rules, and updates to the firewall itself. Since the former is going to be turned into a read/write lock instead of a mutex, a new lock