Re: [libvirt] [PATCH v2 3/4] log: support logging using shell wildcard syntax

2018-05-11 Thread Daniel P . Berrangé
On Mon, Apr 30, 2018 at 11:05:48AM -0400, John Ferlan wrote: > > > On 04/23/2018 08:28 AM, Daniel P. Berrangé wrote: > > Rather than specialcasing handling of the '*' character, use fnmatch() > > to get normal shell wildcard syntax, as described in 'man glob(7)'. > > > > To get an indication of

Re: [libvirt] [PATCH v2 3/4] log: support logging using shell wildcard syntax

2018-04-30 Thread John Ferlan
On 04/23/2018 08:28 AM, Daniel P. Berrangé wrote: > Rather than specialcasing handling of the '*' character, use fnmatch() > to get normal shell wildcard syntax, as described in 'man glob(7)'. > > To get an indication of the performance impact of using globs instead > of plain string matches, a

[libvirt] [PATCH v2 3/4] log: support logging using shell wildcard syntax

2018-04-23 Thread Daniel P . Berrangé
Rather than specialcasing handling of the '*' character, use fnmatch() to get normal shell wildcard syntax, as described in 'man glob(7)'. To get an indication of the performance impact of using globs instead of plain string matches, a test program was written. The list of all 260 log categories w