Re: [libvirt] [PATCH v2 3/5] Extend nwfilter schema to accept comment attributes

2010-10-07 Thread Daniel Veillard
On Thu, Sep 30, 2010 at 07:31:56AM -0400, Stefan Berger wrote: On 09/28/2010 04:06 PM, Stefan Berger wrote: [...] you have a printable character. Which goes back to my suggestion of an inverse charset - rejecting bytes that are known to be non-printable ASCII, and letting everything else

Re: [libvirt] [PATCH v2 3/5] Extend nwfilter schema to accept comment attributes

2010-09-30 Thread Stefan Berger
On 09/28/2010 04:06 PM, Stefan Berger wrote: Eric Blake ebl...@redhat.com wrote on 09/28/2010 03:26:48 PM: [image removed] Re: [libvirt] [PATCH v2 3/5] Extend nwfilter schema to accept comment attributes Eric Blake to: Stefan Berger 09/28/2010 03:27 PM Cc: libvir-list On 09

Re: [libvirt] [PATCH v2 3/5] Extend nwfilter schema to accept comment attributes

2010-09-28 Thread Stefan Berger
Eric Blake ebl...@redhat.com wrote on 09/27/2010 05:07:47 PM: On 09/27/2010 12:40 PM, Stefan Berger wrote: Extend the nwfilter.rng schema to accept comment attributes for all protocol types. Signed-off-by: Stefan Berger stef...@us.ibm.com + define name=comment-attribute +

Re: [libvirt] [PATCH v2 3/5] Extend nwfilter schema to accept comment attributes

2010-09-28 Thread Eric Blake
On 09/28/2010 04:28 AM, Stefan Berger wrote: okay. It also leaves out 8-bit bytes - could that be a problem for i18n where people want comments with native-language accented characters? That is, are we being too strict here? Maybe a better pattern would be to reject specific non-printing

Re: [libvirt] [PATCH v2 3/5] Extend nwfilter schema to accept comment attributes

2010-09-28 Thread Stefan Berger
Eric Blake ebl...@redhat.com wrote on 09/28/2010 03:26:48 PM: [image removed] Re: [libvirt] [PATCH v2 3/5] Extend nwfilter schema to accept comment attributes Eric Blake to: Stefan Berger 09/28/2010 03:27 PM Cc: libvir-list On 09/28/2010 04:28 AM, Stefan Berger wrote

[libvirt] [PATCH v2 3/5] Extend nwfilter schema to accept comment attributes

2010-09-27 Thread Stefan Berger
Extend the nwfilter.rng schema to accept comment attributes for all protocol types. Signed-off-by: Stefan Berger stef...@us.ibm.com --- docs/schemas/nwfilter.rng | 38 ++ 1 file changed, 38 insertions(+) Index: libvirt-acl/docs/schemas/nwfilter.rng