Re: [libvirt] [PATCH v2 3/5] qemu_domain.c: moving maxCpu validation to qemuDomainDefValidate

2018-11-15 Thread Daniel Henrique Barboza
On 11/15/18 7:38 PM, John Ferlan wrote: On 11/14/18 2:52 PM, Daniel Henrique Barboza wrote: Adding maxCpu validation in qemuDomainDefValidate allows the user to spot over the board maxCpus counts at editing time, instead of facing a runtime error when starting the domain. This check is also

Re: [libvirt] [PATCH v2 3/5] qemu_domain.c: moving maxCpu validation to qemuDomainDefValidate

2018-11-15 Thread John Ferlan
On 11/14/18 2:52 PM, Daniel Henrique Barboza wrote: > Adding maxCpu validation in qemuDomainDefValidate allows the user to > spot over the board maxCpus counts at editing time, instead of > facing a runtime error when starting the domain. This check is also > arch independent. > > This leaves

[libvirt] [PATCH v2 3/5] qemu_domain.c: moving maxCpu validation to qemuDomainDefValidate

2018-11-14 Thread Daniel Henrique Barboza
Adding maxCpu validation in qemuDomainDefValidate allows the user to spot over the board maxCpus counts at editing time, instead of facing a runtime error when starting the domain. This check is also arch independent. This leaves us with 2 calls to qemuProcessValidateCpuCount: one in