On Tue, 2017-04-04 at 13:50 +0200, Peter Krempa wrote:
> > > +#undef DO_TEST_GLUSTER_LOOKUP_NATIVE
> > > +#undef DO_TEST_GLUSTER_LOOKUP_NETFS
> > > +#undef DO_TEST_GLUSTER_LOOKUP_FULL
> >
> > The #undefs are a bit unnecessary in this context, I'd leave
> > them out.
>
> It's true that it would be
On Mon, Apr 03, 2017 at 17:03:43 +0200, Andrea Bolognani wrote:
> On Thu, 2017-03-30 at 17:12 +0200, Peter Krempa wrote:
[...]
> > +virstorageutiltest_LDADD = \
> > + ../src/libvirt_driver_storage_impl.la \
> > + $(LDADDS) \
> > + $(NULL)
> > +
[...]
> You should also be able to use $(qem
On Thu, 2017-03-30 at 17:12 +0200, Peter Krempa wrote:
[...]
> @@ -352,7 +354,7 @@ test_programs += nwfilterxml2firewalltest
> endif WITH_NWFILTER
>
> if WITH_STORAGE
> -test_programs += storagevolxml2argvtest
> +test_programs += storagevolxml2argvtest virstorageutiltest
Since you have to touch
Add a test program called virstorageutiltest and test the gluster pool
detection code.
---
tests/Makefile.am | 15 ++-
.../gluster-parse-basic-native.xml | 6 ++
.../gluster-parse-basic-netfs.xml | 7 ++
.../virstorageutildata/
