Re: [libvirt] [PATCH v2 3/8] all: Use realpath() instead of canonicalize_file_name()

2018-05-02 Thread Pino Toscano
On Wednesday, 2 May 2018 18:32:25 CEST Daniel P. Berrangé wrote: > On Mon, Apr 30, 2018 at 06:52:58PM +0200, Andrea Bolognani wrote: > > The latter is a glibc extension that's not available on other > > operating systems, notably FreeBSD. > > > > So far we have worked around the issue through

Re: [libvirt] [PATCH v2 3/8] all: Use realpath() instead of canonicalize_file_name()

2018-05-02 Thread Andrea Bolognani
On Wed, 2018-05-02 at 17:32 +0100, Daniel P. Berrangé wrote: > On Mon, Apr 30, 2018 at 06:52:58PM +0200, Andrea Bolognani wrote: > > The latter is a glibc extension that's not available on other > > operating systems, notably FreeBSD. > > > > So far we have worked around the issue through gnulib,

Re: [libvirt] [PATCH v2 3/8] all: Use realpath() instead of canonicalize_file_name()

2018-05-02 Thread Daniel P . Berrangé
On Wed, May 02, 2018 at 05:32:25PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 30, 2018 at 06:52:58PM +0200, Andrea Bolognani wrote: > > The latter is a glibc extension that's not available on other > > operating systems, notably FreeBSD. > > > > So far we have worked around the issue through

Re: [libvirt] [PATCH v2 3/8] all: Use realpath() instead of canonicalize_file_name()

2018-05-02 Thread Daniel P . Berrangé
On Mon, Apr 30, 2018 at 06:52:58PM +0200, Andrea Bolognani wrote: > The latter is a glibc extension that's not available on other > operating systems, notably FreeBSD. > > So far we have worked around the issue through gnulib, but that > makes it difficult to use mocking in our test suite, so

[libvirt] [PATCH v2 3/8] all: Use realpath() instead of canonicalize_file_name()

2018-04-30 Thread Andrea Bolognani
The latter is a glibc extension that's not available on other operating systems, notably FreeBSD. So far we have worked around the issue through gnulib, but that makes it difficult to use mocking in our test suite, so just drop it in favor of the portable alternative. Signed-off-by: Andrea