Re: [libvirt] [PATCH v2 31/32] qemu: Use the 'device_id' property of SCSI disks to avoid regressing

2019-02-08 Thread Peter Krempa
On Fri, Feb 08, 2019 at 08:29:07 +0100, Peter Krempa wrote: > On Thu, Feb 07, 2019 at 18:15:06 +0100, Ján Tomko wrote: > > On Mon, Feb 04, 2019 at 04:47:04PM +0100, Peter Krempa wrote: > > > QEMU accidentally exposed the id of -drive (or same value as disk > > > serial, if provided) in one of the i

Re: [libvirt] [PATCH v2 31/32] qemu: Use the 'device_id' property of SCSI disks to avoid regressing

2019-02-07 Thread Peter Krempa
On Thu, Feb 07, 2019 at 18:15:06 +0100, Ján Tomko wrote: > On Mon, Feb 04, 2019 at 04:47:04PM +0100, Peter Krempa wrote: > > QEMU accidentally exposed the id of -drive (or same value as disk > > serial, if provided) in one of the identifiers visible from the guest. > > > > To avoid regression in c

Re: [libvirt] [PATCH v2 31/32] qemu: Use the 'device_id' property of SCSI disks to avoid regressing

2019-02-07 Thread Ján Tomko
On Mon, Feb 04, 2019 at 04:47:04PM +0100, Peter Krempa wrote: QEMU accidentally exposed the id of -drive (or same value as disk serial, if provided) in one of the identifiers visible from the guest. To avoid regression in case when -blockdev will be used we need to always specify it ourselves.

[libvirt] [PATCH v2 31/32] qemu: Use the 'device_id' property of SCSI disks to avoid regressing

2019-02-04 Thread Peter Krempa
QEMU accidentally exposed the id of -drive (or same value as disk serial, if provided) in one of the identifiers visible from the guest. To avoid regression in case when -blockdev will be used we need to always specify it ourselves. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c