Re: [libvirt] [PATCH v2 32/32] util: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageSource

2019-02-11 Thread Erik Skultety
> So from your output it seems: > > virStorageFileMetadataNew > virStorageFileGetMetadataFromFD > virStorageSourceCopy > virStorageSourceUpdateCapacity > virStorageSourceNewFromBackingAbsolute > virStorageSourceNewFromBacking > virStorageFileGetMetadataRecurse > virStorageFileGetBackingStoreStr >

Re: [libvirt] [PATCH v2 32/32] util: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageSource

2019-02-11 Thread John Ferlan
On 2/11/19 8:45 AM, Erik Skultety wrote: > On Mon, Feb 11, 2019 at 08:33:32AM -0500, John Ferlan wrote: >> >> >> On 2/11/19 7:44 AM, Erik Skultety wrote: >>> On Fri, Feb 08, 2019 at 01:37:26PM -0500, John Ferlan wrote: Let's make use of the auto __cleanup capabilities cleaning up any

Re: [libvirt] [PATCH v2 32/32] util: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageSource

2019-02-11 Thread Ján Tomko
On Fri, Feb 08, 2019 at 01:37:26PM -0500, John Ferlan wrote: Let's make use of the auto __cleanup capabilities cleaning up any now unnecessary goto paths. Signed-off-by: John Ferlan --- src/conf/domain_conf.c| 3 +- src/qemu/qemu_domain.c| 3 +-

Re: [libvirt] [PATCH v2 32/32] util: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageSource

2019-02-11 Thread Erik Skultety
On Mon, Feb 11, 2019 at 08:33:32AM -0500, John Ferlan wrote: > > > On 2/11/19 7:44 AM, Erik Skultety wrote: > > On Fri, Feb 08, 2019 at 01:37:26PM -0500, John Ferlan wrote: > >> Let's make use of the auto __cleanup capabilities cleaning up any > >> now unnecessary goto paths. > >> > >>

Re: [libvirt] [PATCH v2 32/32] util: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageSource

2019-02-11 Thread John Ferlan
On 2/11/19 7:44 AM, Erik Skultety wrote: > On Fri, Feb 08, 2019 at 01:37:26PM -0500, John Ferlan wrote: >> Let's make use of the auto __cleanup capabilities cleaning up any >> now unnecessary goto paths. >> >> Signed-off-by: John Ferlan >> --- > ... >> target->backingStore->type =

Re: [libvirt] [PATCH v2 32/32] util: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageSource

2019-02-11 Thread Erik Skultety
On Fri, Feb 08, 2019 at 01:37:26PM -0500, John Ferlan wrote: > Let's make use of the auto __cleanup capabilities cleaning up any > now unnecessary goto paths. > > Signed-off-by: John Ferlan > --- ... > target->backingStore->type = VIR_STORAGE_TYPE_NETWORK; >

[libvirt] [PATCH v2 32/32] util: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageSource

2019-02-08 Thread John Ferlan
Let's make use of the auto __cleanup capabilities cleaning up any now unnecessary goto paths. Signed-off-by: John Ferlan --- src/conf/domain_conf.c| 3 +- src/qemu/qemu_domain.c| 3 +- src/qemu/qemu_driver.c| 9 +- src/qemu/qemu_migration.c