Re: [libvirt] [PATCH v2 4/4] storage: Report error from VolOpen if proper flag is passed

2014-04-01 Thread Ján Tomko
On 03/31/2014 08:50 PM, Cole Robinson wrote: VolOpen notifies the user of a potentially non-fatal failure by returning -2 and logging a VIR_WARN or VIR_INFO. Unfortunately most callers treat -2 as fatal but don't actually report any message with the error APIs. Change VolOpen to report an

Re: [libvirt] [PATCH v2 4/4] storage: Report error from VolOpen if proper flag is passed

2014-04-01 Thread Eric Blake
On 04/01/2014 02:56 AM, Ján Tomko wrote: On 03/31/2014 08:50 PM, Cole Robinson wrote: VolOpen notifies the user of a potentially non-fatal failure by returning -2 and logging a VIR_WARN or VIR_INFO. Unfortunately most callers treat -2 as fatal but don't actually report any message with the

[libvirt] [PATCH v2 4/4] storage: Report error from VolOpen if proper flag is passed

2014-03-31 Thread Cole Robinson
VolOpen notifies the user of a potentially non-fatal failure by returning -2 and logging a VIR_WARN or VIR_INFO. Unfortunately most callers treat -2 as fatal but don't actually report any message with the error APIs. Change VolOpen to report an error if the VOL_OPEN_ERROR flag is passed. The ony

Re: [libvirt] [PATCH v2 4/4] storage: Report error from VolOpen if proper flag is passed

2014-03-31 Thread Daniel P. Berrange
On Mon, Mar 31, 2014 at 02:50:48PM -0400, Cole Robinson wrote: diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index e02d17f..4d44897 100644 --- a/src/storage/storage_backend_fs.c +++ b/src/storage/storage_backend_fs.c @@ -904,8 +907,9 @@

Re: [libvirt] [PATCH v2 4/4] storage: Report error from VolOpen if proper flag is passed

2014-03-31 Thread Cole Robinson
On 03/31/2014 03:08 PM, Daniel P. Berrange wrote: On Mon, Mar 31, 2014 at 02:50:48PM -0400, Cole Robinson wrote: diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index e02d17f..4d44897 100644 --- a/src/storage/storage_backend_fs.c +++

Re: [libvirt] [PATCH v2 4/4] storage: Report error from VolOpen if proper flag is passed

2014-03-31 Thread Eric Blake
On 03/31/2014 12:50 PM, Cole Robinson wrote: VolOpen notifies the user of a potentially non-fatal failure by returning -2 and logging a VIR_WARN or VIR_INFO. Unfortunately most callers treat -2 as fatal but don't actually report any message with the error APIs. Change VolOpen to report an