Re: [libvirt] [PATCH v2 4/5] conf: report errors when parsing video resolution

2019-11-14 Thread Cole Robinson
On 11/13/19 5:41 PM, Jonathon Jongsma wrote: > On Wed, 2019-11-13 at 13:54 -0500, Cole Robinson wrote: >> I pushed the first three patches. Comments below >> >> On 10/23/19 1:46 PM, Jonathon Jongsma wrote: >>> The current code doesn't properly handle errors when parsing a >>> video >>> device's

Re: [libvirt] [PATCH v2 4/5] conf: report errors when parsing video resolution

2019-11-13 Thread Jonathon Jongsma
On Wed, 2019-11-13 at 13:54 -0500, Cole Robinson wrote: > I pushed the first three patches. Comments below > > On 10/23/19 1:46 PM, Jonathon Jongsma wrote: > > The current code doesn't properly handle errors when parsing a > > video > > device's resolution. > > > > This patch changes the parse

Re: [libvirt] [PATCH v2 4/5] conf: report errors when parsing video resolution

2019-11-13 Thread Cole Robinson
I pushed the first three patches. Comments below On 10/23/19 1:46 PM, Jonathon Jongsma wrote: > The current code doesn't properly handle errors when parsing a video > device's resolution. > > This patch changes the parse function signature to return an error > when we're missing an 'x' or 'y'

[libvirt] [PATCH v2 4/5] conf: report errors when parsing video resolution

2019-10-23 Thread Jonathon Jongsma
The current code doesn't properly handle errors when parsing a video device's resolution. This patch changes the parse function signature to return an error when we're missing an 'x' or 'y' parameter or when the 'x' or 'y' parameters are not positive integers. No error is returned when no