Re: [libvirt] [PATCH v2 4/5] domain: Define explicit flags for saved image xml

2019-02-22 Thread Eric Blake
On 2/19/19 1:44 PM, John Ferlan wrote: > > > On 2/14/19 4:29 PM, Eric Blake wrote: >> Commit d2a929d4 (0.9.4) defined virDomainSaveImageGetXMLDesc()'s use >> of @flags as a subset of virDomainXMLFlags, documenting that 2 of the >> 3 flags defined at the time would never be valid. Later, commit

Re: [libvirt] [PATCH v2 4/5] domain: Define explicit flags for saved image xml

2019-02-22 Thread John Ferlan
On 2/14/19 4:29 PM, Eric Blake wrote: > Commit d2a929d4 (0.9.4) defined virDomainSaveImageGetXMLDesc()'s use > of @flags as a subset of virDomainXMLFlags, documenting that 2 of the > 3 flags defined at the time would never be valid. Later, commit > 28f8dfdc (1.0.0) introduced a new flag,

Re: [libvirt] [PATCH v2 4/5] domain: Define explicit flags for saved image xml

2019-02-22 Thread John Ferlan
On 2/14/19 4:29 PM, Eric Blake wrote: > Commit d2a929d4 (0.9.4) defined virDomainSaveImageGetXMLDesc()'s use > of @flags as a subset of virDomainXMLFlags, documenting that 2 of the > 3 flags defined at the time would never be valid. Later, commit > 28f8dfdc (1.0.0) introduced a new flag,

Re: [libvirt] [PATCH v2 4/5] domain: Define explicit flags for saved image xml

2019-02-19 Thread Eric Blake
On 2/19/19 1:38 PM, John Ferlan wrote: > > > On 2/14/19 4:29 PM, Eric Blake wrote: >> Commit d2a929d4 (0.9.4) defined virDomainSaveImageGetXMLDesc()'s use >> of @flags as a subset of virDomainXMLFlags, documenting that 2 of the >> 3 flags defined at the time would never be valid. Later, commit

[libvirt] [PATCH v2 4/5] domain: Define explicit flags for saved image xml

2019-02-14 Thread Eric Blake
Commit d2a929d4 (0.9.4) defined virDomainSaveImageGetXMLDesc()'s use of @flags as a subset of virDomainXMLFlags, documenting that 2 of the 3 flags defined at the time would never be valid. Later, commit 28f8dfdc (1.0.0) introduced a new flag, VIR_DOMAIN_XML_MIGRATABLE, but did not adjust the save