Re: [libvirt] [PATCH v2 4/5] qemu: Don't report false error from MigrateFinish

2015-07-17 Thread Daniel P. Berrange
On Fri, Jul 10, 2015 at 11:26:17AM +0200, Jiri Denemark wrote: > virDomainMigrateFinish* APIs were unfortunately designed to return the > pointer to the domain on destination and NULL on error. This looks OK in > normal cases but the same API is also called when we know migration > failed and thus

[libvirt] [PATCH v2 4/5] qemu: Don't report false error from MigrateFinish

2015-07-10 Thread Jiri Denemark
virDomainMigrateFinish* APIs were unfortunately designed to return the pointer to the domain on destination and NULL on error. This looks OK in normal cases but the same API is also called when we know migration failed and thus we expect Finish to return NULL even if it actually did all it was supp