Re: [libvirt] [PATCH v2 5/5] snapshot: Define explicit flags for snapshot xml

2019-02-22 Thread John Ferlan
On 2/14/19 4:29 PM, Eric Blake wrote: > Commit f609cb85 (0.9.5) introduced virDomainSnapshotGetXMLDesc()'s use > of @flags as a subset of virDomainXMLFlags, documenting that 2 of the > 3 flags defined at the time would never be valid. Later, commit > 28f8dfdc (1.0.0) introduced a new flag,

[libvirt] [PATCH v2 5/5] snapshot: Define explicit flags for snapshot xml

2019-02-14 Thread Eric Blake
Commit f609cb85 (0.9.5) introduced virDomainSnapshotGetXMLDesc()'s use of @flags as a subset of virDomainXMLFlags, documenting that 2 of the 3 flags defined at the time would never be valid. Later, commit 28f8dfdc (1.0.0) introduced a new flag, VIR_DOMAIN_XML_MIGRATABLE, but did not adjust the