Re: [libvirt] [PATCH v2 5/7] snapshot: Rework virDomainSnapshotState enum

2019-02-27 Thread Eric Blake
On 2/27/19 2:04 PM, Eric Blake wrote: > The existing virDomainSnapshotState is a superset of virDomainState, > adding one more state (disk-snapshot) on top of valid domain states. > But as written, the enum cannot be used for gcc validation that all > enum values are covered in a strongly-typed swi

[libvirt] [PATCH v2 5/7] snapshot: Rework virDomainSnapshotState enum

2019-02-27 Thread Eric Blake
The existing virDomainSnapshotState is a superset of virDomainState, adding one more state (disk-snapshot) on top of valid domain states. But as written, the enum cannot be used for gcc validation that all enum values are covered in a strongly-typed switch condition, because the enum does not expli