Re: [libvirt] [PATCH v2 5/8] storageVolWipePattern: Don't take shortcut to refreshPool()

2019-03-16 Thread Michal Prívozník
On 3/15/19 3:14 PM, Pavel Hrdina wrote: > On Wed, Mar 06, 2019 at 03:59:15PM +0100, Michal Privoznik wrote: >> In d16f803d780 we've tried to solve an issue that after wiping an >> image its format might have changed (e.g. from qcow2 to raw) but >> libvirt wasn't probing the image format. We fixed

Re: [libvirt] [PATCH v2 5/8] storageVolWipePattern: Don't take shortcut to refreshPool()

2019-03-15 Thread Pavel Hrdina
On Wed, Mar 06, 2019 at 03:59:15PM +0100, Michal Privoznik wrote: > In d16f803d780 we've tried to solve an issue that after wiping an > image its format might have changed (e.g. from qcow2 to raw) but > libvirt wasn't probing the image format. We fixed this by calling >

[libvirt] [PATCH v2 5/8] storageVolWipePattern: Don't take shortcut to refreshPool()

2019-03-06 Thread Michal Privoznik
In d16f803d780 we've tried to solve an issue that after wiping an image its format might have changed (e.g. from qcow2 to raw) but libvirt wasn't probing the image format. We fixed this by calling virStorageBackendRefreshVolTargetUpdate() which is what refreshPool() would end up calling. But this