Re: [libvirt] [PATCH v2 6/6] streams: Report errors if sendAll/recvAll callbacks fail

2017-06-01 Thread Daniel P. Berrange
On Thu, Jun 01, 2017 at 02:23:30PM +0200, Martin Kletzander wrote: > On Thu, Jun 01, 2017 at 01:10:45PM +0100, Daniel P. Berrange wrote: > > On Thu, Jun 01, 2017 at 02:02:14PM +0200, Michal Privoznik wrote: > > > We have couple of wrappers over our low level stream APIs: > > > virSreamRecvAll(), vi

Re: [libvirt] [PATCH v2 6/6] streams: Report errors if sendAll/recvAll callbacks fail

2017-06-01 Thread Martin Kletzander
On Thu, Jun 01, 2017 at 01:10:45PM +0100, Daniel P. Berrange wrote: On Thu, Jun 01, 2017 at 02:02:14PM +0200, Michal Privoznik wrote: We have couple of wrappers over our low level stream APIs: virSreamRecvAll(), virStreamSendAll() and their sparse stream variants. All of them take some callbacks

Re: [libvirt] [PATCH v2 6/6] streams: Report errors if sendAll/recvAll callbacks fail

2017-06-01 Thread Daniel P. Berrange
On Thu, Jun 01, 2017 at 02:02:14PM +0200, Michal Privoznik wrote: > We have couple of wrappers over our low level stream APIs: > virSreamRecvAll(), virStreamSendAll() and their sparse stream > variants. All of them take some callbacks and call them at > appropriate times. If a callback fails it abo

[libvirt] [PATCH v2 6/6] streams: Report errors if sendAll/recvAll callbacks fail

2017-06-01 Thread Michal Privoznik
We have couple of wrappers over our low level stream APIs: virSreamRecvAll(), virStreamSendAll() and their sparse stream variants. All of them take some callbacks and call them at appropriate times. If a callback fails it aborts the whole operation. However, if it so happens that the callback fails