Re: [libvirt] [PATCH v2 6/7] virsh: domstate: report detailed state if available

2019-04-01 Thread Bjoern Walk
Michal Privoznik [2019-04-01, 02:08PM +0200]: > On 4/1/19 1:14 PM, Bjoern Walk wrote: > > Michal Privoznik [2019-04-01, 10:49AM +0200]: > > > On 4/1/19 10:17 AM, Bjoern Walk wrote: > > > > I intent to have the new API function superseed the existing one, so I > > > > actually want to call virDoma

Re: [libvirt] [PATCH v2 6/7] virsh: domstate: report detailed state if available

2019-04-01 Thread Michal Privoznik
On 4/1/19 1:14 PM, Bjoern Walk wrote: Michal Privoznik [2019-04-01, 10:49AM +0200]: On 4/1/19 10:17 AM, Bjoern Walk wrote: I intent to have the new API function superseed the existing one, so I actually want to call virDomainGetStateParams() unconditionally and only fall back to virshDomainSta

Re: [libvirt] [PATCH v2 6/7] virsh: domstate: report detailed state if available

2019-04-01 Thread Bjoern Walk
Michal Privoznik [2019-04-01, 10:49AM +0200]: > On 4/1/19 10:17 AM, Bjoern Walk wrote: > > I intent to have the new API function superseed the existing one, so I > > actually want to call virDomainGetStateParams() unconditionally and only > > fall back to virshDomainState() when the new API is not

Re: [libvirt] [PATCH v2 6/7] virsh: domstate: report detailed state if available

2019-04-01 Thread Michal Privoznik
On 4/1/19 10:17 AM, Bjoern Walk wrote: Michal Privoznik [2019-03-27, 02:05PM +0100]: On 3/25/19 9:04 AM, Bjoern Walk wrote: +case VIR_DOMAIN_STATE_INFO_TYPE_QEMU_S390: { +int core; +unsigned long long psw_mask; +unsigned long long psw_addr; +const char *reas

Re: [libvirt] [PATCH v2 6/7] virsh: domstate: report detailed state if available

2019-04-01 Thread Bjoern Walk
Michal Privoznik [2019-03-27, 02:05PM +0100]: > On 3/25/19 9:04 AM, Bjoern Walk wrote: > > +case VIR_DOMAIN_STATE_INFO_TYPE_QEMU_S390: { > > +int core; > > +unsigned long long psw_mask; > > +unsigned long long psw_addr; > > +const char *reason; > > + > > +

Re: [libvirt] [PATCH v2 6/7] virsh: domstate: report detailed state if available

2019-03-27 Thread Michal Privoznik
On 3/25/19 9:04 AM, Bjoern Walk wrote: > Add a new parameter to virsh domstate, --info, to report additional > information for the domain state, e.g. for a QEMU guest running a S390 > domain: > > virsh # domstate --info guest-1 > crashed (panicked: s390: core='0' psw-mask='0x000200018000

[libvirt] [PATCH v2 6/7] virsh: domstate: report detailed state if available

2019-03-25 Thread Bjoern Walk
Add a new parameter to virsh domstate, --info, to report additional information for the domain state, e.g. for a QEMU guest running a S390 domain: virsh # domstate --info guest-1 crashed (panicked: s390: core='0' psw-mask='0x000200018000' \ psw-addr='0x0010f146' re