Re: [libvirt] [PATCH v2 7/9] qemu: add helper for getting full FSInfo

2019-08-23 Thread Daniel Henrique Barboza
On 8/23/19 11:00 AM, Jonathon Jongsma wrote: On Thu, 2019-08-22 at 19:02 -0300, Daniel Henrique Barboza wrote: [...] Hmm, sorry for the sloppiness. I ran these tests multiple times, but apparently after a final rebase, I introduced something that I failed to catch before submitting. Thanks

Re: [libvirt] [PATCH v2 7/9] qemu: add helper for getting full FSInfo

2019-08-23 Thread Jonathon Jongsma
On Thu, 2019-08-22 at 19:02 -0300, Daniel Henrique Barboza wrote: > This patch fails to compile in my env throwing this error: > > > CC qemuagenttest.o > qemuagenttest.c: In function > 'testQemuAgentGetFSInfoCommon.constprop': > qemuagenttest.c:242:5: error: 'ret_def' may be used

Re: [libvirt] [PATCH v2 7/9] qemu: add helper for getting full FSInfo

2019-08-22 Thread Daniel Henrique Barboza
This patch fails to compile in my env throwing this error:   CC   qemuagenttest.o qemuagenttest.c: In function 'testQemuAgentGetFSInfoCommon.constprop': qemuagenttest.c:242:5: error: 'ret_def' may be used uninitialized in this function [-Werror=maybe-uninitialized]   242 |

[libvirt] [PATCH v2 7/9] qemu: add helper for getting full FSInfo

2019-08-21 Thread Jonathon Jongsma
This function adds the complete filesystem information returned by the qemu agent to an array of typed parameters with field names intended to to be returned by virDomainGetGuestInfo() --- src/qemu/qemu_agent.c | 89 ++ src/qemu/qemu_agent.h | 5 + tests/qemuagenttest.c | 210