Re: [libvirt] [PATCH v2 8/8] qemu: Utilize qemu secret objects for SCSI/RBD auth/secret

2016-05-05 Thread John Ferlan
>> qemuBuildiSCSICommandLine: (private) >> Required for iSCSI since qemu only processes the "user=" and >> "password-secret=" options for an "-iscsi" entry. At some point >> in a future release, qemu may support those options on the -drive >> command line for iscsi devices. The

Re: [libvirt] [PATCH v2 8/8] qemu: Utilize qemu secret objects for SCSI/RBD auth/secret

2016-05-05 Thread John Ferlan
[...] >> diff --git a/configure.ac b/configure.ac >> index 88e2e20..3cabd5e 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -1264,6 +1264,7 @@ if test "x$with_gnutls" != "xno"; then >>]]) >> >>AC_CHECK_FUNCS([gnutls_rnd]) >> + AC_CHECK_FUNCS([gnutls_cipher_encrypt]) > > This c

Re: [libvirt] [PATCH v2 8/8] qemu: Utilize qemu secret objects for SCSI/RBD auth/secret

2016-05-05 Thread Daniel P. Berrange
On Mon, May 02, 2016 at 05:51:15PM -0400, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1182074 > > If they're available and we need to pass secrets to qemu, then use the > qemu domain secret object in order to pass the secrets for iSCSI and > RBD volumes instead of passing plai

Re: [libvirt] [PATCH v2 8/8] qemu: Utilize qemu secret objects for SCSI/RBD auth/secret

2016-05-04 Thread Michal Privoznik
On 02.05.2016 23:51, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1182074 > > If they're available and we need to pass secrets to qemu, then use the > qemu domain secret object in order to pass the secrets for iSCSI and > RBD volumes instead of passing plaintext or base64 encod

[libvirt] [PATCH v2 8/8] qemu: Utilize qemu secret objects for SCSI/RBD auth/secret

2016-05-02 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1182074 If they're available and we need to pass secrets to qemu, then use the qemu domain secret object in order to pass the secrets for iSCSI and RBD volumes instead of passing plaintext or base64 encoded secrets on the command line. Adjust the qemuDo