Re: [libvirt] [PATCH v3] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-11-09 Thread Daniel P. Berrange
On Mon, Nov 08, 2010 at 03:17:56PM -0700, Eric Blake wrote: Index: libvirt-acl/src/libvirt.c === --- libvirt-acl.orig/src/libvirt.c +++ libvirt-acl/src/libvirt.c @@ -10794,7 +10794,7 @@ virStreamRef(virStreamPtr stream)

Re: [libvirt] [PATCH v3] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-11-09 Thread Stefan Berger
On 11/09/2010 05:58 AM, Daniel P. Berrange wrote: On Mon, Nov 08, 2010 at 03:17:56PM -0700, Eric Blake wrote: Index: libvirt-acl/src/libvirt.c === --- libvirt-acl.orig/src/libvirt.c +++ libvirt-acl/src/libvirt.c @@ -10794,7

Re: [libvirt] [PATCH v3] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-11-09 Thread Stefan Berger
On 11/08/2010 05:17 PM, Eric Blake wrote: Merge conflict - you can ignore any changes to these two files, now that they is deleted. ACK. You may find some more instances of close() pop up as you rebase on top of the latest tree, but it shouldn't be too hard to figure out. Push now. Stefan

Re: [libvirt] [PATCH v3] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-11-08 Thread Eric Blake
On 11/01/2010 05:16 AM, Stefan Berger wrote: Now that 0.8.5 is out, here is another posting of this big cleanup patch. And I'm finally getting time to look at it. We're early enough in the release cycle that even if I missed something in this review, hopefully we get enough test exposure before

Re: [libvirt] [PATCH v3] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-11-08 Thread Stefan Berger
On 11/08/2010 05:17 PM, Eric Blake wrote: Index: libvirt-acl/src/libvirt.c === --- libvirt-acl.orig/src/libvirt.c +++ libvirt-acl/src/libvirt.c @@ -10794,7 +10794,7 @@ virStreamRef(virStreamPtr stream) * ... report an