[libvirt] [PATCH v3] deprecate fclose() and introduce VIR_{FORCE_}FCLOSE()

2010-11-16 Thread Stefan Berger
V3: - fixes from V2 review + one lost hunk - diff(tree+V2, tree+v3) at bottom of email V2: - following Eric's suggestion, deprecating fdclose(), introducing VIR_FDCLOSE() - following some other nits that Eric pointed out - replaced some more fclose () I previously had missed (last 2

Re: [libvirt] [PATCH v3] deprecate fclose() and introduce VIR_{FORCE_}FCLOSE()

2010-11-16 Thread Eric Blake
On 11/16/2010 04:50 AM, Stefan Berger wrote: V3: - fixes from V2 review + one lost hunk - diff(tree+V2, tree+v3) at bottom of email That helps. And you solved all my findings. ACK. +++ src/xen/xen_driver.c2010-11-16 06:31:49.722481846 -0500 @@ -218,9 +218,9 @@ #endif #ifdef

Re: [libvirt] [PATCH v3] deprecate fclose() and introduce VIR_{FORCE_}FCLOSE()

2010-11-16 Thread Stefan Berger
On 11/16/2010 10:37 AM, Eric Blake wrote: On 11/16/2010 04:50 AM, Stefan Berger wrote: V3: - fixes from V2 review + one lost hunk - diff(tree+V2, tree+v3) at bottom of email That helps. And you solved all my findings. ACK. +++ src/xen/xen_driver.c2010-11-16 06:31:49.722481846