Re: [libvirt] [PATCH v3] interfaces: Convert virInterfaceObjList to virObjectRWLockable

2017-10-19 Thread John Ferlan
[...] >>> >>> With the patch split in 2 introducing 2 distinct changes + the NULL check: >>> Reviewed-by: Erik Skultety >> >> Hopefully you reconsider the desire for 2 patches... > > Well, since I was apparently fine with the change when reviewing the same > changes to nodedev, I guess I should

Re: [libvirt] [PATCH v3] interfaces: Convert virInterfaceObjList to virObjectRWLockable

2017-10-19 Thread Erik Skultety
On Thu, Oct 19, 2017 at 10:48:56AM -0400, John Ferlan wrote: > > > On 10/19/2017 10:07 AM, Erik Skultety wrote: > > On Fri, Oct 13, 2017 at 07:45:01AM -0400, John Ferlan wrote: > >> Rather than a forward linked list, let's use the ObjectRWLockable object > >> in order to manage the data. > >> > >>

Re: [libvirt] [PATCH v3] interfaces: Convert virInterfaceObjList to virObjectRWLockable

2017-10-19 Thread John Ferlan
On 10/19/2017 10:07 AM, Erik Skultety wrote: > On Fri, Oct 13, 2017 at 07:45:01AM -0400, John Ferlan wrote: >> Rather than a forward linked list, let's use the ObjectRWLockable object >> in order to manage the data. >> >> Requires numerous changes from List to Object management similar to >> many

Re: [libvirt] [PATCH v3] interfaces: Convert virInterfaceObjList to virObjectRWLockable

2017-10-19 Thread Erik Skultety
On Fri, Oct 13, 2017 at 07:45:01AM -0400, John Ferlan wrote: > Rather than a forward linked list, let's use the ObjectRWLockable object > in order to manage the data. > > Requires numerous changes from List to Object management similar to > many other drivers/vir*obj.c modules > This patch should

[libvirt] [PATCH v3] interfaces: Convert virInterfaceObjList to virObjectRWLockable

2017-10-13 Thread John Ferlan
Rather than a forward linked list, let's use the ObjectRWLockable object in order to manage the data. Requires numerous changes from List to Object management similar to many other drivers/vir*obj.c modules Signed-off-by: John Ferlan --- This is the real one - I need more coffee. src/conf/vir