Re: [libvirt] [PATCH v3] nwfilter: extend nwfilter reload support

2010-08-16 Thread Eric Blake
On 08/16/2010 11:23 AM, Stefan Berger wrote: >> >> This identation still seems to be wrong - so was the code being >> replaced. ACK aside from that >> >> >> Daniel > > > Pushed. > (This indentation issue must be related to something Thunderbird 3.1.1 > does to emails). Odd indeed. But good to

Re: [libvirt] [PATCH v3] nwfilter: extend nwfilter reload support

2010-08-16 Thread Stefan Berger
libvir-list-boun...@redhat.com wrote on 08/16/2010 12:09:48 PM: > Please respond to "Daniel P. Berrange" > > On Fri, Aug 13, 2010 at 04:36:32PM -0400, Stefan Berger wrote: > > > > > > This time with a proper title. > > > > v3: > > - Fixed an indentation problem > > > > - added bool p

Re: [libvirt] [PATCH v3] nwfilter: extend nwfilter reload support

2010-08-16 Thread Daniel P. Berrange
On Fri, Aug 13, 2010 at 04:36:32PM -0400, Stefan Berger wrote: > > > This time with a proper title. > > v3: > - Fixed an indentation problem > > - added bool parameter to function terminating the IP address > learner threads to determine whether future threads may still run > (needed

[libvirt] [PATCH v3] nwfilter: extend nwfilter reload support

2010-08-13 Thread Stefan Berger
This time with a proper title. v3: - Fixed an indentation problem - added bool parameter to function terminating the IP address learner threads to determine whether future threads may still run (needed in case of driver reload) or all must terminate (need in case of libvirtd termina