Re: [libvirt] [PATCH v3] qemu: Add callback struct for qemuBuildCommandLine

2013-05-17 Thread Osier Yang
Ping? since it's mainly for fixing the build failure, better to get it in as soon as possible. Osier On 16/05/13 23:02, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is to find out the scsi generic

Re: [libvirt] [PATCH v3] qemu: Add callback struct for qemuBuildCommandLine

2013-05-17 Thread Daniel P. Berrange
On Thu, May 16, 2013 at 11:02:00PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is to find out the scsi generic device name by adpater:bus:target:unit), there is no way to work around, qemu

Re: [libvirt] [PATCH v3] qemu: Add callback struct for qemuBuildCommandLine

2013-05-17 Thread Osier Yang
On 17/05/13 18:12, Daniel P. Berrange wrote: On Thu, May 16, 2013 at 11:02:00PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is to find out the scsi generic device name by

Re: [libvirt] [PATCH v3] qemu: Add callback struct for qemuBuildCommandLine

2013-05-17 Thread Daniel P. Berrange
On Fri, May 17, 2013 at 06:17:07PM +0800, Osier Yang wrote: On 17/05/13 18:12, Daniel P. Berrange wrote: On Thu, May 16, 2013 at 11:02:00PM +0800, Osier Yang wrote: Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is to

[libvirt] [PATCH v3] qemu: Add callback struct for qemuBuildCommandLine

2013-05-16 Thread Osier Yang
Since 0d70656afded, it starts to access the sysfs files to build the qemu command line (by virSCSIDeviceGetSgName, which is to find out the scsi generic device name by adpater:bus:target:unit), there is no way to work around, qemu wants to see the scsi generic device like /dev/sg6 anyway. And