Re: [libvirt] [PATCH v3] qemu: add virQEMUBuildBufferEscapeComma in qemu_command.c

2018-04-15 Thread John Ferlan
On 04/12/2018 05:40 PM, Sukrit Bhatnagar wrote: > Incremental patches do look better. Just to make sure I am on the right > track, I have some queries. > > I have to apply the changes one function at a time, and these changes > will be the same ones I made in the v2 and v3 patches, right? yes,

Re: [libvirt] [PATCH v3] qemu: add virQEMUBuildBufferEscapeComma in qemu_command.c

2018-04-15 Thread Sukrit Bhatnagar
Incremental patches do look better. Just to make sure I am on the right track, I have some queries. I have to apply the changes one function at a time, and these changes will be the same ones I made in the v2 and v3 patches, right? If that is the case, do I need the next patch to be v4 or can the

Re: [libvirt] [PATCH v3] qemu: add virQEMUBuildBufferEscapeComma in qemu_command.c

2018-04-10 Thread John Ferlan
On 04/02/2018 04:17 PM, Sukrit Bhatnagar wrote: > This patch adds virQEMUBuildBufferEscapeComma to properly > escape commas in user provided data fields for qemu command > line processing. > > Signed-off-by: Sukrit Bhatnagar > --- > > Thank you for the helpful feedback

[libvirt] [PATCH v3] qemu: add virQEMUBuildBufferEscapeComma in qemu_command.c

2018-04-02 Thread Sukrit Bhatnagar
This patch adds virQEMUBuildBufferEscapeComma to properly escape commas in user provided data fields for qemu command line processing. Signed-off-by: Sukrit Bhatnagar --- Thank you for the helpful feedback and apologies for the delay. Changes in v3: