[libvirt] [PATCH v3] storage: Report error from VolOpen by default

2014-04-02 Thread Cole Robinson
Currently VolOpen notifies the user of a potentially non-fatal failure by returning -2 and logging a VIR_WARN or VIR_INFO. Unfortunately most callers treat -2 as fatal but don't actually report any message with the error APIs. Rename the VOL_OPEN_ERROR flag to VOL_OPEN_NOERROR. If NOERROR is

Re: [libvirt] [PATCH v3] storage: Report error from VolOpen by default

2014-04-02 Thread Eric Blake
On 04/02/2014 09:54 AM, Cole Robinson wrote: Currently VolOpen notifies the user of a potentially non-fatal failure by returning -2 and logging a VIR_WARN or VIR_INFO. Unfortunately most callers treat -2 as fatal but don't actually report any message with the error APIs. Rename the

Re: [libvirt] [PATCH v3] storage: Report error from VolOpen by default

2014-04-02 Thread Cole Robinson
On 04/02/2014 12:36 PM, Eric Blake wrote: On 04/02/2014 09:54 AM, Cole Robinson wrote: Currently VolOpen notifies the user of a potentially non-fatal failure by returning -2 and logging a VIR_WARN or VIR_INFO. Unfortunately most callers treat -2 as fatal but don't actually report any message