Re: [libvirt] [PATCH v3] virsh: avoid missing zero value judgement in cmdBlkiotune

2011-07-28 Thread Michal Privoznik
On 28.07.2011 12:38, Alex Jia wrote: On 07/28/2011 05:50 PM, Wen Congyang wrote: At 07/28/2011 05:52 PM, Alex Jia Write: * tools/virsh.c: avoid missing zero value judgement in cmdBlkiotune, when weight is equal to 0, the cmdBlkiotune will not raise any error information when judge weight value

Re: [libvirt] [PATCH v3] virsh: avoid missing zero value judgement in cmdBlkiotune

2011-07-28 Thread Alex Jia
On 07/28/2011 05:50 PM, Wen Congyang wrote: At 07/28/2011 05:52 PM, Alex Jia Write: * tools/virsh.c: avoid missing zero value judgement in cmdBlkiotune, when weight is equal to 0, the cmdBlkiotune will not raise any error information when judge weight value first time, and execute else bra

Re: [libvirt] [PATCH v3] virsh: avoid missing zero value judgement in cmdBlkiotune

2011-07-28 Thread Wen Congyang
At 07/28/2011 05:52 PM, Alex Jia Write: > * tools/virsh.c: avoid missing zero value judgement in cmdBlkiotune, when > weight is equal to 0, the cmdBlkiotune will not raise any error information > when judge weight value first time, and execute else branch to judge weight > value again, strncp

[libvirt] [PATCH v3] virsh: avoid missing zero value judgement in cmdBlkiotune

2011-07-28 Thread ajia
* tools/virsh.c: avoid missing zero value judgement in cmdBlkiotune, when weight is equal to 0, the cmdBlkiotune will not raise any error information when judge weight value first time, and execute else branch to judge weight value again, strncpy(temp->field, VIR_DOMAIN_BLKIO_WEIGHT, sizeof(