Re: [libvirt] [PATCH v3 01/11] libvirt: Export libvirt config getters by moving them to util

2015-11-16 Thread Martin Kletzander
On Fri, Nov 06, 2015 at 12:46:16PM +0100, Erik Skultety wrote: virConnectGetConfig and virConnectGetConfigPath were static libvirt methods, merely because there hasn't been any need for having them internally exported yet. Since libvirt-admin also needs to reference libvirt config file,

Re: [libvirt] [PATCH v3 01/11] libvirt: Export libvirt config getters by moving them to util

2015-11-06 Thread Daniel P. Berrange
On Fri, Nov 06, 2015 at 12:46:16PM +0100, Erik Skultety wrote: > virConnectGetConfig and virConnectGetConfigPath were static libvirt > methods, merely because there hasn't been any need for having them > internally exported yet. Since libvirt-admin also needs to reference > libvirt config file,

[libvirt] [PATCH v3 01/11] libvirt: Export libvirt config getters by moving them to util

2015-11-06 Thread Erik Skultety
virConnectGetConfig and virConnectGetConfigPath were static libvirt methods, merely because there hasn't been any need for having them internally exported yet. Since libvirt-admin also needs to reference libvirt config file, 'xGetConfig' should be exported. Besides moving, this patch also renames