Re: [libvirt] [PATCH v3 01/13] Introduce a virQEMUDriverConfigPtr object

2013-02-07 Thread Viktor Mihajlovski
On 02/07/2013 04:58 PM, Daniel P. Berrange wrote: Actually we can just update the virQEMUDriverConfigPtr object after it has been created to hardcode the path in the test suite. indeed ... sometimes I am too ... structured. Sigh. As I am currently fixing up my build environment anyway, I can d

Re: [libvirt] [PATCH v3 01/13] Introduce a virQEMUDriverConfigPtr object

2013-02-07 Thread Daniel P. Berrange
On Thu, Feb 07, 2013 at 04:51:51PM +0100, Viktor Mihajlovski wrote: > On 02/01/2013 12:18 PM, Daniel P. Berrange wrote: > >diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c > >index ee48333..46c1892 100644 > >--- a/src/qemu/qemu_conf.c > >+++ b/src/qemu/qemu_conf.c > Sorry for not noticing e

Re: [libvirt] [PATCH v3 01/13] Introduce a virQEMUDriverConfigPtr object

2013-02-07 Thread Viktor Mihajlovski
On 02/01/2013 12:18 PM, Daniel P. Berrange wrote: diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index ee48333..46c1892 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c Sorry for not noticing earlier, but -if (!(driver->vncTLSx509certdir = strdup(SYSCONFDIR "/pki/libv

Re: [libvirt] [PATCH v3 01/13] Introduce a virQEMUDriverConfigPtr object

2013-02-05 Thread Jiri Denemark
On Tue, Feb 05, 2013 at 11:43:36 +, Daniel P. Berrange wrote: ... > Here are the changes I propose - should adress every point you > mention. ACK to the original patch with these modifications squashed in. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailma

Re: [libvirt] [PATCH v3 01/13] Introduce a virQEMUDriverConfigPtr object

2013-02-05 Thread Daniel P. Berrange
On Fri, Feb 01, 2013 at 09:20:25PM +0100, Jiri Denemark wrote: > On Fri, Feb 01, 2013 at 11:18:23 +, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > Currently the virQEMUDriverPtr struct contains an wide variety > > of data with varying access needs. Move all the static confi

Re: [libvirt] [PATCH v3 01/13] Introduce a virQEMUDriverConfigPtr object

2013-02-01 Thread Jiri Denemark
On Fri, Feb 01, 2013 at 11:18:23 +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Currently the virQEMUDriverPtr struct contains an wide variety > of data with varying access needs. Move all the static config > data into a dedicated virQEMUDriverConfigPtr object. The only > locki