Re: [libvirt] [PATCH v3 01/14] migration: refactor: get rid of use_params p2p_full

2015-09-25 Thread Jiri Denemark
On Fri, Sep 18, 2015 at 18:05:39 +0300, Nikolay Shirokovskiy wrote: > 'useParams' parameter usage is an example of control coupling. Most of the > work > inside the function is done differently except for the uri check. Lets split > this function into two, one with extensible parameters set and

[libvirt] [PATCH v3 01/14] migration: refactor: get rid of use_params p2p_full

2015-09-18 Thread Nikolay Shirokovskiy
'useParams' parameter usage is an example of control coupling. Most of the work inside the function is done differently except for the uri check. Lets split this function into two, one with extensible parameters set and one with hardcoded parameter set. Signed-off-by: Nikolay Shirokovskiy