Re: [libvirt] [PATCH v3 01/18] blockcopy: allow larger buf-size

2014-09-04 Thread Peter Krempa
On 09/01/14 16:57, Jiri Denemark wrote: On Sat, Aug 30, 2014 at 22:02:19 -0600, Eric Blake wrote: While qemu definitely caps granularity to 64 MiB, it places no limits on buf-size. On a machine beefy enough for lots of memory, a buf-size larger than 2 GiB is feasible, so we should pass a

Re: [libvirt] [PATCH v3 01/18] blockcopy: allow larger buf-size

2014-09-01 Thread Jiri Denemark
On Sat, Aug 30, 2014 at 22:02:19 -0600, Eric Blake wrote: While qemu definitely caps granularity to 64 MiB, it places no limits on buf-size. On a machine beefy enough for lots of memory, a buf-size larger than 2 GiB is feasible, so we should pass a 64-bit parameter. *

[libvirt] [PATCH v3 01/18] blockcopy: allow larger buf-size

2014-08-30 Thread Eric Blake
While qemu definitely caps granularity to 64 MiB, it places no limits on buf-size. On a machine beefy enough for lots of memory, a buf-size larger than 2 GiB is feasible, so we should pass a 64-bit parameter. * include/libvirt/libvirt.h.in (VIR_DOMAIN_BLOCK_COPY_BUF_SIZE): Allow 64 bits.