Re: [libvirt] [PATCH v3 03/22] build-aux: rewrite po file minimizer in Python

2019-09-27 Thread Daniel P . Berrangé
On Fri, Sep 27, 2019 at 09:22:13AM +0200, Erik Skultety wrote: > On Thu, Sep 26, 2019 at 04:38:49PM +0100, Daniel P. Berrangé wrote: > > On Thu, Sep 26, 2019 at 05:34:49PM +0200, Ján Tomko wrote: > > > On Thu, Sep 26, 2019 at 02:16:04PM +0100, Daniel P. Berrangé wrote: > > > > On Thu, Sep 26, 2019

Re: [libvirt] [PATCH v3 03/22] build-aux: rewrite po file minimizer in Python

2019-09-27 Thread Erik Skultety
On Thu, Sep 26, 2019 at 04:38:49PM +0100, Daniel P. Berrangé wrote: > On Thu, Sep 26, 2019 at 05:34:49PM +0200, Ján Tomko wrote: > > On Thu, Sep 26, 2019 at 02:16:04PM +0100, Daniel P. Berrangé wrote: > > > On Thu, Sep 26, 2019 at 12:39:39PM +0200, Erik Skultety wrote: > > > > On Tue, Sep 24, 2019

Re: [libvirt] [PATCH v3 03/22] build-aux: rewrite po file minimizer in Python

2019-09-26 Thread Daniel P . Berrangé
On Thu, Sep 26, 2019 at 05:34:49PM +0200, Ján Tomko wrote: > On Thu, Sep 26, 2019 at 02:16:04PM +0100, Daniel P. Berrangé wrote: > > On Thu, Sep 26, 2019 at 12:39:39PM +0200, Erik Skultety wrote: > > > On Tue, Sep 24, 2019 at 03:58:44PM +0100, Daniel P. Berrangé wrote: > > > question 1) what's the

Re: [libvirt] [PATCH v3 03/22] build-aux: rewrite po file minimizer in Python

2019-09-26 Thread Ján Tomko
On Thu, Sep 26, 2019 at 02:16:04PM +0100, Daniel P. Berrangé wrote: On Thu, Sep 26, 2019 at 12:39:39PM +0200, Erik Skultety wrote: On Tue, Sep 24, 2019 at 03:58:44PM +0100, Daniel P. Berrangé wrote: question 1) what's the benefit of compiling a regex and using it only once? Btw python does

Re: [libvirt] [PATCH v3 03/22] build-aux: rewrite po file minimizer in Python

2019-09-26 Thread Daniel P . Berrangé
On Thu, Sep 26, 2019 at 12:39:39PM +0200, Erik Skultety wrote: > On Tue, Sep 24, 2019 at 03:58:44PM +0100, Daniel P. Berrangé wrote: > > As part of an goal to eliminate Perl from libvirt build tools, > > rewrite the minimize-po.pl tool in Python. > > > > This was a straight conversion, manually

Re: [libvirt] [PATCH v3 03/22] build-aux: rewrite po file minimizer in Python

2019-09-26 Thread Erik Skultety
On Tue, Sep 24, 2019 at 03:58:44PM +0100, Daniel P. Berrangé wrote: > As part of an goal to eliminate Perl from libvirt build tools, > rewrite the minimize-po.pl tool in Python. > > This was a straight conversion, manually going line-by-line to > change the syntax from Perl to Python. Thus the

[libvirt] [PATCH v3 03/22] build-aux: rewrite po file minimizer in Python

2019-09-24 Thread Daniel P . Berrangé
As part of an goal to eliminate Perl from libvirt build tools, rewrite the minimize-po.pl tool in Python. This was a straight conversion, manually going line-by-line to change the syntax from Perl to Python. Thus the overall structure of the file and approach is the same. Signed-off-by: Daniel