Re: [libvirt] [PATCH v3 04/10] util: Management routines for scsi_host devices

2016-11-14 Thread John Ferlan
On 11/14/2016 05:06 PM, Eric Farman wrote: > > > On 11/14/2016 04:40 PM, John Ferlan wrote: >> >> On 11/14/2016 03:38 PM, Eric Farman wrote: >>> >>> On 11/11/2016 04:44 PM, John Ferlan wrote: While perhaps mostly obvious - you need some sort of commit message here. On

Re: [libvirt] [PATCH v3 04/10] util: Management routines for scsi_host devices

2016-11-14 Thread Eric Farman
On 11/14/2016 04:40 PM, John Ferlan wrote: On 11/14/2016 03:38 PM, Eric Farman wrote: On 11/11/2016 04:44 PM, John Ferlan wrote: While perhaps mostly obvious - you need some sort of commit message here. On 11/08/2016 01:26 PM, Eric Farman wrote: Signed-off-by: Eric Farman

Re: [libvirt] [PATCH v3 04/10] util: Management routines for scsi_host devices

2016-11-14 Thread John Ferlan
On 11/14/2016 03:38 PM, Eric Farman wrote: > > > On 11/11/2016 04:44 PM, John Ferlan wrote: >> While perhaps mostly obvious - you need some sort of commit message here. >> >> On 11/08/2016 01:26 PM, Eric Farman wrote: >>> Signed-off-by: Eric Farman >>> --- >>>

Re: [libvirt] [PATCH v3 04/10] util: Management routines for scsi_host devices

2016-11-14 Thread Eric Farman
On 11/11/2016 04:44 PM, John Ferlan wrote: While perhaps mostly obvious - you need some sort of commit message here. On 11/08/2016 01:26 PM, Eric Farman wrote: Signed-off-by: Eric Farman --- po/POTFILES.in | 1 + src/Makefile.am | 1 +

Re: [libvirt] [PATCH v3 04/10] util: Management routines for scsi_host devices

2016-11-11 Thread John Ferlan
While perhaps mostly obvious - you need some sort of commit message here. On 11/08/2016 01:26 PM, Eric Farman wrote: > Signed-off-by: Eric Farman > --- > po/POTFILES.in | 1 + > src/Makefile.am | 1 + > src/libvirt_private.syms | 19 +++ >

[libvirt] [PATCH v3 04/10] util: Management routines for scsi_host devices

2016-11-08 Thread Eric Farman
Signed-off-by: Eric Farman --- po/POTFILES.in | 1 + src/Makefile.am | 1 + src/libvirt_private.syms | 19 +++ src/util/virhost.c | 299 +++ src/util/virhost.h | 72

[libvirt] [PATCH v3 04/10] util: Management routines for scsi_host devices

2016-10-31 Thread Eric Farman
Signed-off-by: Eric Farman --- src/Makefile.am | 1 + src/libvirt_private.syms | 19 +++ src/util/virhost.c | 301 +++ src/util/virhost.h | 72 src/util/virhostdev.c| 155