Re: [libvirt] [PATCH v3 04/13] Merge virDomainObjListIsDuplicate into virDomainObjListAdd

2013-02-05 Thread Jiri Denemark
On Tue, Feb 05, 2013 at 14:48:01 +, Daniel P. Berrange wrote: > On Mon, Feb 04, 2013 at 04:58:25PM +0100, Jiri Denemark wrote: > > On Fri, Feb 01, 2013 at 11:18:26 +, Daniel P. Berrange wrote: > > > From: "Daniel P. Berrange" > > > > > > The duplicate VM checking should be done atomically

Re: [libvirt] [PATCH v3 04/13] Merge virDomainObjListIsDuplicate into virDomainObjListAdd

2013-02-05 Thread Daniel P. Berrange
On Mon, Feb 04, 2013 at 04:58:25PM +0100, Jiri Denemark wrote: > On Fri, Feb 01, 2013 at 11:18:26 +, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" > > > > The duplicate VM checking should be done atomically with > > virDomainObjListAdd, so shoud not be a separate function. > > Inst

Re: [libvirt] [PATCH v3 04/13] Merge virDomainObjListIsDuplicate into virDomainObjListAdd

2013-02-04 Thread Jiri Denemark
On Fri, Feb 01, 2013 at 11:18:26 +, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The duplicate VM checking should be done atomically with > virDomainObjListAdd, so shoud not be a separate function. > Instead just use flags to indicate what kind of checks are > required. > ... >

[libvirt] [PATCH v3 04/13] Merge virDomainObjListIsDuplicate into virDomainObjListAdd

2013-02-01 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The duplicate VM checking should be done atomically with virDomainObjListAdd, so shoud not be a separate function. Instead just use flags to indicate what kind of checks are required. This pair, used in virDomainCreateXML: if (virDomainObjListIsDuplicate(privconn->