Re: [libvirt] [PATCH v3 06/13] docs: only generate function argument info for args with a description

2013-02-06 Thread Eric Blake
On 02/06/2013 09:13 AM, Claudio Bley wrote: >>> Note, however, that I have no deep understanding about what it means >>> when a function ought to be "ignored" by apibuild.py. >>> >>> Should we skip this function from the generated HTML documentation >>> perhaps? >> >> Indeed, when you frame the qu

Re: [libvirt] [PATCH v3 06/13] docs: only generate function argument info for args with a description

2013-02-06 Thread Claudio Bley
At Fri, 01 Feb 2013 10:22:28 -0700, Eric Blake wrote: > > On 02/01/2013 05:48 AM, Claudio Bley wrote: > > The point is, we skip checking all functions contained in the > > "ignored_functions" dictionary in apibuild.py. > > > > We would have to do the same filtering inside the stylesheet also. > >

Re: [libvirt] [PATCH v3 06/13] docs: only generate function argument info for args with a description

2013-02-01 Thread Eric Blake
On 02/01/2013 05:48 AM, Claudio Bley wrote: > The point is, we skip checking all functions contained in the > "ignored_functions" dictionary in apibuild.py. > > We would have to do the same filtering inside the stylesheet also. > > But why bother? We never get to XSL processing when apibuild.py f

Re: [libvirt] [PATCH v3 06/13] docs: only generate function argument info for args with a description

2013-02-01 Thread Claudio Bley
At Fri, 01 Feb 2013 13:48:45 +0100, Claudio Bley wrote: > > At Thu, 31 Jan 2013 13:41:10 -0700, > Eric Blake wrote: > > > > On 01/30/2013 08:38 AM, Claudio Bley wrote: > > > When function arguments or return values lack a description there's no > > > use in generating a meaningless "ARG1: " stanz

Re: [libvirt] [PATCH v3 06/13] docs: only generate function argument info for args with a description

2013-02-01 Thread Claudio Bley
At Thu, 31 Jan 2013 13:41:10 -0700, Eric Blake wrote: > > On 01/30/2013 08:38 AM, Claudio Bley wrote: > > When function arguments or return values lack a description there's no > > use in generating a meaningless "ARG1: " stanza. > > Can you point to an example of an argument lacking a descriptio

Re: [libvirt] [PATCH v3 06/13] docs: only generate function argument info for args with a description

2013-01-31 Thread Eric Blake
On 01/30/2013 08:38 AM, Claudio Bley wrote: > When function arguments or return values lack a description there's no > use in generating a meaningless "ARG1: " stanza. Can you point to an example of an argument lacking a description? This is another case where I think we're better off fixing thin

[libvirt] [PATCH v3 06/13] docs: only generate function argument info for args with a description

2013-01-30 Thread Claudio Bley
When function arguments or return values lack a description there's no use in generating a meaningless "ARG1: " stanza. Signed-off-by: Claudio Bley --- docs/newapi.xsl |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/newapi.xsl b/docs/newapi.xsl index 0d32e55..fb95