Re: [libvirt] [PATCH v3 06/18] conf: Rename API's in storage_adapter_conf

2017-03-15 Thread John Ferlan
[...] int -virStoragePoolSourceAdapterParseValidate(virStoragePoolDefPtr ret) +virStorageAdapterParseValidate(virStoragePoolDefPtr ret) >>> >>> This function should take a virStoragePoolSourceAdapterPtr rather than >>> virStoragePoolDefPtr, and the name should just be >>> "virSt

Re: [libvirt] [PATCH v3 06/18] conf: Rename API's in storage_adapter_conf

2017-03-14 Thread Laine Stump
On 03/14/2017 07:05 PM, John Ferlan wrote: > > On 03/11/2017 09:41 PM, Laine Stump wrote: >> Ah, but wait! I ACKed this too soon! *This* is the patch that's renaming the >> functions. It should be changing the arguments in some cases too (and at >> least one of the names seems wrong). >> >> >> On

Re: [libvirt] [PATCH v3 06/18] conf: Rename API's in storage_adapter_conf

2017-03-14 Thread John Ferlan
On 03/11/2017 09:41 PM, Laine Stump wrote: > Ah, but wait! I ACKed this too soon! *This* is the patch that's renaming the > functions. It should be changing the arguments in some cases too (and at > least one of the names seems wrong). > > > On 03/10/2017 04:10 PM, John Ferlan wrote: >> Renam

Re: [libvirt] [PATCH v3 06/18] conf: Rename API's in storage_adapter_conf

2017-03-11 Thread Laine Stump
Ah, but wait! I ACKed this too soon! *This* is the patch that's renaming the functions. It should be changing the arguments in some cases too (and at least one of the names seems wrong). On 03/10/2017 04:10 PM, John Ferlan wrote: > Rename the API's to remove the storage pool source pieces Yeah

Re: [libvirt] [PATCH v3 06/18] conf: Rename API's in storage_adapter_conf

2017-03-11 Thread Laine Stump
On 03/10/2017 04:10 PM, John Ferlan wrote: > Rename the API's to remove the storage pool source pieces > > Signed-off-by: John Ferlan > --- > src/conf/storage_adapter_conf.c | 14 +++--- > src/conf/storage_adapter_conf.h | 14 +++--- > src/conf/storage_conf.c | 8

[libvirt] [PATCH v3 06/18] conf: Rename API's in storage_adapter_conf

2017-03-10 Thread John Ferlan
Rename the API's to remove the storage pool source pieces Signed-off-by: John Ferlan --- src/conf/storage_adapter_conf.c | 14 +++--- src/conf/storage_adapter_conf.h | 14 +++--- src/conf/storage_conf.c | 8 src/libvirt_private.syms| 8 4 files