Re: [libvirt] [PATCH v3 07/17] qemu: Implement NVDIMM

2017-03-15 Thread Michal Privoznik
On 03/14/2017 02:36 PM, John Ferlan wrote: > > > On 03/09/2017 11:06 AM, Michal Privoznik wrote: >> So, majority of the code is just ready as-is. Well, with one >> slight change: differentiate between dimm and nvdimm in places >> like device alias generation, generating the command line and so

Re: [libvirt] [PATCH v3 07/17] qemu: Implement NVDIMM

2017-03-14 Thread John Ferlan
On 03/09/2017 11:06 AM, Michal Privoznik wrote: > So, majority of the code is just ready as-is. Well, with one > slight change: differentiate between dimm and nvdimm in places > like device alias generation, generating the command line and so > on. > > Speaking of the command line, we also need

[libvirt] [PATCH v3 07/17] qemu: Implement NVDIMM

2017-03-09 Thread Michal Privoznik
So, majority of the code is just ready as-is. Well, with one slight change: differentiate between dimm and nvdimm in places like device alias generation, generating the command line and so on. Speaking of the command line, we also need to append 'nvdimm=on' to the '-machine' argument so that the