On Thu, Nov 19, 2015 at 02:00:16PM +0100, Erik Skultety wrote:
-if (!(conn->uri = virURIParse(uri ? uri : default_uri)))
+if ((!(flags & VIR_CONNECT_NO_ALIASES) &&
+ virURIResolveAlias(conf, uri ? uri : default_uri, ) < 0))
this should also be fixed (with what I mentioned in
>> -if (!(conn->uri = virURIParse(uri ? uri : default_uri)))
>> +if ((!(flags & VIR_CONNECT_NO_ALIASES) &&
>> + virURIResolveAlias(conf, uri ? uri : default_uri, ) < 0))
>
> this should also be fixed (with what I mentioned in previous review).
>
Fixed.
>> +goto error;
On Fri, Nov 06, 2015 at 12:46:23PM +0100, Erik Skultety wrote:
Now that we introduced URI support in libvirt-admin, we should also support URI
aliases during connection establishment phase. After applying this patch,
virAdmConnectOpen will also support VIR_CONNECT_NO_ALIASES flag.
---
Now that we introduced URI support in libvirt-admin, we should also support URI
aliases during connection establishment phase. After applying this patch,
virAdmConnectOpen will also support VIR_CONNECT_NO_ALIASES flag.
---
src/libvirt-admin.c | 9 -
1 file changed, 8 insertions(+), 1