Re: [libvirt] [PATCH v3 08/14] virsh: Create macro for common "file" option

2016-01-11 Thread John Ferlan
On 01/11/2016 09:38 AM, Andrea Bolognani wrote: > On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: >> Rather than continually cut-n-paste the strings into each command, >> create a common macro to be used generically. Note that not all >> '{.name = "file",' entries are replaced, just those

Re: [libvirt] [PATCH v3 08/14] virsh: Create macro for common "file" option

2016-01-11 Thread Andrea Bolognani
On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Rather than continually cut-n-paste the strings into each command, > create a common macro to be used generically.  Note that not all > '{.name = "file",' entries are replaced, just those that use > VSH_OT_DATA and VSH_OFLAG_REQ. >  >

[libvirt] [PATCH v3 08/14] virsh: Create macro for common "file" option

2016-01-09 Thread John Ferlan
Rather than continually cut-n-paste the strings into each command, create a common macro to be used generically. Note that not all '{.name = "file",' entries are replaced, just those that use VSH_OT_DATA and VSH_OFLAG_REQ. Replacement of this option is a bit trickier, since the .helpstr changes