Re: [libvirt] [PATCH v3 09/14] virsh: Create macros for common "pool" options

2016-01-12 Thread Andrea Bolognani
On Mon, 2016-01-11 at 18:03 -0500, John Ferlan wrote: > I've also lift/applied the "helpstr" to each of the # define > VIRSH_COMMON_OPT_*'s in virsh.h (meaning virsh.h is not included in > po/POTFILES.in either).  That also picks up a couple more domain options > from virsh-domain.c which use

Re: [libvirt] [PATCH v3 09/14] virsh: Create macros for common "pool" options

2016-01-12 Thread Ján Tomko
On Mon, Jan 11, 2016 at 04:39:25PM +0100, Andrea Bolognani wrote: > On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > > Rather than continually cut-n-paste the strings into each command, > > create common macros to be used generically.  For virsh-volume, there > > are 3 different types of

Re: [libvirt] [PATCH v3 09/14] virsh: Create macros for common "pool" options

2016-01-12 Thread Andrea Bolognani
On Tue, 2016-01-12 at 09:28 +0100, Ján Tomko wrote: >  > > > +#define VIRSH_COMMON_OPT_VOLUME_POOL_CREATE\ > > > +{.name = "pool",   \ > > > + .type = VSH_OT_DATA,  \ > > > + .flags = VSH_OFLAG_REQ, 

Re: [libvirt] [PATCH v3 09/14] virsh: Create macros for common "pool" options

2016-01-11 Thread John Ferlan
On 01/11/2016 10:39 AM, Andrea Bolognani wrote: > On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: >> Rather than continually cut-n-paste the strings into each command, >> create common macros to be used generically. For virsh-volume, there >> are 3 different types of "pool" options - 2

Re: [libvirt] [PATCH v3 09/14] virsh: Create macros for common "pool" options

2016-01-11 Thread Andrea Bolognani
On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote: > Rather than continually cut-n-paste the strings into each command, > create common macros to be used generically.  For virsh-volume, there > are 3 different types of "pool" options - 2 for create, 2 required > for the command, and 10 for

[libvirt] [PATCH v3 09/14] virsh: Create macros for common "pool" options

2016-01-09 Thread John Ferlan
Rather than continually cut-n-paste the strings into each command, create common macros to be used generically. For virsh-volume, there are 3 different types of "pool" options - 2 for create, 2 required for the command, and 10 for string type options. Create 2 new macros for the create and string