Re: [libvirt] [PATCH v3 1/4] Gathering vhostuser interface stats with ovs

2016-12-09 Thread Mehdi Abaakouk
On Fri, Dec 09, 2016 at 10:36:32AM +0100, Michal Privoznik wrote: Awesome. This is working for me. Therefore I went ahead, fixed all the small nits raised during review and pushed patches 1-3. As discussed in patch 4, we probably want different approach anyway so I have not pushed that one. Co

Re: [libvirt] [PATCH v3 1/4] Gathering vhostuser interface stats with ovs

2016-12-09 Thread Michal Privoznik
On 08.12.2016 15:35, Mehdi Abaakouk wrote: >>> -if (ret == 0) >>> -ret = virNetInterfaceStats(path, stats); >>> -else >>> +if (net) { >>> +if (net->type == VIR_DOMAIN_NET_TYPE_VHOSTUSER) { >>> +ret = virNetDevOpenvswitchInterfaceStats(path, stats); >>> +

Re: [libvirt] [PATCH v3 1/4] Gathering vhostuser interface stats with ovs

2016-12-08 Thread Mehdi Abaakouk
-if (ret == 0) -ret = virNetInterfaceStats(path, stats); -else +if (net) { +if (net->type == VIR_DOMAIN_NET_TYPE_VHOSTUSER) { +ret = virNetDevOpenvswitchInterfaceStats(path, stats); +} else { +ret = virNetInterfaceStats(path, stats); +

Re: [libvirt] [PATCH v3 1/4] Gathering vhostuser interface stats with ovs

2016-12-08 Thread Michal Privoznik
On 18.11.2016 23:51, Mehdi Abaakouk wrote: > From: Mehdi Abaakouk > > When vhostuser interfaces are used, the interface statistics > are not available in /proc/net/dev. > > This change looks at the openvswitch interfaces statistics > tables to provide this information for vhostuser interface. >

[libvirt] [PATCH v3 1/4] Gathering vhostuser interface stats with ovs

2016-11-18 Thread Mehdi Abaakouk
From: Mehdi Abaakouk When vhostuser interfaces are used, the interface statistics are not available in /proc/net/dev. This change looks at the openvswitch interfaces statistics tables to provide this information for vhostuser interface. Note that in openvswitch world drop/error doesn't always m