Re: [libvirt] [PATCH v3 1/6] virfdstream: Check for thread error more frequently

2017-06-13 Thread John Ferlan
On 06/13/2017 09:26 AM, Michal Privoznik wrote: > On 06/13/2017 02:35 PM, John Ferlan wrote: >> >> >> On 06/13/2017 07:31 AM, Michal Privoznik wrote: >>> On 06/12/2017 11:26 PM, John Ferlan wrote: On 06/05/2017 04:22 AM, Michal Privoznik wrote: > When the I/O thread quits

Re: [libvirt] [PATCH v3 1/6] virfdstream: Check for thread error more frequently

2017-06-13 Thread Michal Privoznik
On 06/13/2017 02:35 PM, John Ferlan wrote: > > > On 06/13/2017 07:31 AM, Michal Privoznik wrote: >> On 06/12/2017 11:26 PM, John Ferlan wrote: >>> >>> >>> On 06/05/2017 04:22 AM, Michal Privoznik wrote: When the I/O thread quits (e.g. due to an I/O error, lseek() error, whatever), any

Re: [libvirt] [PATCH v3 1/6] virfdstream: Check for thread error more frequently

2017-06-13 Thread John Ferlan
On 06/13/2017 07:31 AM, Michal Privoznik wrote: > On 06/12/2017 11:26 PM, John Ferlan wrote: >> >> >> On 06/05/2017 04:22 AM, Michal Privoznik wrote: >>> When the I/O thread quits (e.g. due to an I/O error, lseek() >>> error, whatever), any subsequent virFDStream API should return >>> error too.

Re: [libvirt] [PATCH v3 1/6] virfdstream: Check for thread error more frequently

2017-06-13 Thread Michal Privoznik
On 06/12/2017 11:26 PM, John Ferlan wrote: > > > On 06/05/2017 04:22 AM, Michal Privoznik wrote: >> When the I/O thread quits (e.g. due to an I/O error, lseek() >> error, whatever), any subsequent virFDStream API should return >> error too. Moreover, when invoking stream event callback, we must

Re: [libvirt] [PATCH v3 1/6] virfdstream: Check for thread error more frequently

2017-06-12 Thread John Ferlan
On 06/05/2017 04:22 AM, Michal Privoznik wrote: > When the I/O thread quits (e.g. due to an I/O error, lseek() > error, whatever), any subsequent virFDStream API should return > error too. Moreover, when invoking stream event callback, we must > set the VIR_STREAM_EVENT_ERROR flag so that the

[libvirt] [PATCH v3 1/6] virfdstream: Check for thread error more frequently

2017-06-05 Thread Michal Privoznik
When the I/O thread quits (e.g. due to an I/O error, lseek() error, whatever), any subsequent virFDStream API should return error too. Moreover, when invoking stream event callback, we must set the VIR_STREAM_EVENT_ERROR flag so that the callback knows something bad happened. Signed-off-by: