Re: [libvirt] [PATCH v3 1/9] lib: add virDomainGetGuestInfo()

2019-08-28 Thread Jonathon Jongsma
On Wed, 2019-08-28 at 16:37 +0100, Daniel P. Berrangé wrote: > On Fri, Aug 23, 2019 at 11:31:15AM -0500, Jonathon Jongsma wrote: > > This API is intended to aggregate several guest agent information > > queries and is ispired by stats API virDomainListGetStats(). It is > > anticipated that this

Re: [libvirt] [PATCH v3 1/9] lib: add virDomainGetGuestInfo()

2019-08-28 Thread Daniel P . Berrangé
On Fri, Aug 23, 2019 at 11:31:15AM -0500, Jonathon Jongsma wrote: > This API is intended to aggregate several guest agent information > queries and is ispired by stats API virDomainListGetStats(). It is > anticipated that this information will be provided by a guest agent > running within the

Re: [libvirt] [PATCH v3 1/9] lib: add virDomainGetGuestInfo()

2019-08-28 Thread Daniel P . Berrangé
On Fri, Aug 23, 2019 at 11:31:15AM -0500, Jonathon Jongsma wrote: > This API is intended to aggregate several guest agent information > queries and is ispired by stats API virDomainListGetStats(). It is > anticipated that this information will be provided by a guest agent > running within the

Re: [libvirt] [PATCH v3 1/9] lib: add virDomainGetGuestInfo()

2019-08-26 Thread Michal Privoznik
On 8/23/19 6:31 PM, Jonathon Jongsma wrote: This API is intended to aggregate several guest agent information queries and is ispired by stats API virDomainListGetStats(). It is anticipated that this information will be provided by a guest agent running within the domain. Signed-off-by: Jonathon

Re: [libvirt] [PATCH v3 1/9] lib: add virDomainGetGuestInfo()

2019-08-23 Thread Daniel Henrique Barboza
Flagged a couple of typos that can be fixed by the maintainer when pushing upstream or by in a later version, if a new version is needed. Aside for the typos, LGTM: Reviewed-by: Daniel Henrique Barboza Tested-by: Daniel Henrique Barboza On 8/23/19 1:31 PM, Jonathon Jongsma wrote: This

[libvirt] [PATCH v3 1/9] lib: add virDomainGetGuestInfo()

2019-08-23 Thread Jonathon Jongsma
This API is intended to aggregate several guest agent information queries and is ispired by stats API virDomainListGetStats(). It is anticipated that this information will be provided by a guest agent running within the domain. Signed-off-by: Jonathon Jongsma ---