Re: [libvirt] [PATCH v3 12/36] conf: don't pass interface type into virNetDevBandwidthParse

2019-03-22 Thread Laine Stump
On 3/22/19 11:11 AM, Daniel P. Berrangé wrote: On Fri, Mar 22, 2019 at 11:03:59AM -0400, Laine Stump wrote: On 3/19/19 8:46 AM, Daniel P. Berrangé wrote: The virNetDevBandwidthParse method uses the interface type to decide whether to allow use of the "floor" parameter. Using the interface type

Re: [libvirt] [PATCH v3 12/36] conf: don't pass interface type into virNetDevBandwidthParse

2019-03-22 Thread Daniel P . Berrangé
On Fri, Mar 22, 2019 at 11:03:59AM -0400, Laine Stump wrote: > On 3/19/19 8:46 AM, Daniel P. Berrangé wrote: > > The virNetDevBandwidthParse method uses the interface type to decide > > whether to allow use of the "floor" parameter. Using the interface > > type is not convenient as callers may not

Re: [libvirt] [PATCH v3 12/36] conf: don't pass interface type into virNetDevBandwidthParse

2019-03-22 Thread Laine Stump
On 3/19/19 8:46 AM, Daniel P. Berrangé wrote: The virNetDevBandwidthParse method uses the interface type to decide whether to allow use of the "floor" parameter. Using the interface type is not convenient as callers may not have that available, but still wish to allow use of "floor". Switch to

[libvirt] [PATCH v3 12/36] conf: don't pass interface type into virNetDevBandwidthParse

2019-03-19 Thread Daniel P . Berrangé
The virNetDevBandwidthParse method uses the interface type to decide whether to allow use of the "floor" parameter. Using the interface type is not convenient as callers may not have that available, but still wish to allow use of "floor". Switch to an explicit boolean to control its usage.